Skip to content

Bug 1867238: utilize channels from ClusterVersion when available #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 11, 2020
Merged

Bug 1867238: utilize channels from ClusterVersion when available #6283

openshift-merge-robot merged 1 commit into from
Aug 11, 2020

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Aug 10, 2020

Due to the recent addition of cv.status.desired.channels, we cannot make a hard switch over to make use of cv.status.desired.channels as many builds do not yet contain those changes, and removing the hard-coded values outright will break the console for those builds.

https://issues.redhat.com/browse/PD-579 documents some follow-on design items that will need to be addressed in the future.

Screen Shot 2020-08-10 at 2 16 34 PM

resulting from

apiVersion: config.openshift.io/v1
kind: ClusterVersion
metadata:
  creationTimestamp: '2020-08-10T17:44:11Z'
  generation: 6
  name: version
  resourceVersion: '72671'
  selfLink: /apis/config.openshift.io/v1/clusterversions/version
  uid: 00a05f63-ab93-42a7-82e4-8b58a2504203
spec:
  channel: candidate-4.6
  clusterID: caa924e0-11f7-4e8b-a293-0fd0f0a39600
  upstream: 'https://api.openshift.com/api/upgrades_info/v1/graph'
status:
  availableUpdates: null
  conditions:
    - lastTransitionTime: '2020-08-10T18:11:33Z'
      message: Done applying 4.6.0-fc.0
      status: 'True'
      type: Available
    - lastTransitionTime: '2020-08-10T17:56:19Z'
      status: 'False'
      type: Failing
    - lastTransitionTime: '2020-08-10T18:11:33Z'
      message: Cluster version is 4.6.0-fc.0
      status: 'False'
      type: Progressing
    - lastTransitionTime: '2020-08-10T18:59:34Z'
      status: 'True'
      type: RetrievedUpdates
  desired:
    channels:
      - candidate-4.6
    image: >-
      quay.io/openshift-release-dev/ocp-release@sha256:45e6bc583040384efb4033b22c58f054b12ac32c7874554885d74a0faf6fef79
    version: 4.6.0-fc.0
  history:
    - completionTime: '2020-08-10T18:11:33Z'
      image: >-
        quay.io/openshift-release-dev/ocp-release@sha256:45e6bc583040384efb4033b22c58f054b12ac32c7874554885d74a0faf6fef79
      startedTime: '2020-08-10T17:44:18Z'
      state: Completed
      verified: false
      version: 4.6.0-fc.0
  observedGeneration: 6
  versionHash: kVdi1UOYMBM=

cc: @megan-hall

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 10, 2020

@rhamilto: This pull request references Bugzilla bug 1867238, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1867238: utilize channels from ClusterVersion when available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2020
spadgett
spadgett reviewed Aug 10, 2020
View reviewed changes
spadgett
spadgett approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Aug 10, 2020

/hold

It occurs to me it's a bit silly to transform an array to an object and then back to an array.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
spadgett
spadgett approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

rhamilto commented Aug 10, 2020

/hold cancel

@spadgett, please take another look.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit c97c4bd into openshift:master Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2020

@rhamilto: All pull requests linked via external trackers have merged: openshift/console#6283. Bugzilla bug 1867238 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1867238: utilize channels from ClusterVersion when available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the bz1867238 branch August 11, 2020 11:20
@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
@spadgett spadgett mentioned this pull request Nov 4, 2020
Merged
@wking wking mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@wking wking

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.6

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @openshift-ci-robot @spadgett @wking @openshift-merge-robot